Messages in this thread | | | Date | Wed, 3 Oct 2001 18:51:13 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2 |
| |
On Wed, 3 Oct 2001, Christoph Hellwig wrote:
> Hi Al, > > In article <Pine.GSO.4.21.0110031643130.23558-100000@weyl.math.psu.edu> you wrote: > > Moreover, ->release() for block_device also doesn't care for the junk > > we pass - it only uses inode->i_rdev. In all cases. And I'd rather > > see it them as > > int (*open)(struct block_device *bdev, int flags, int mode); > > int (*release)(struct block_device *bdev); > > int (*check_media_change)(struct block_device *bdev); > > int (*revalidate)(struct block_device *bdev); > > - that would make more sense than the current variant. They are block_device > > methods, not file or inode ones, after all. > > How about starting 2.5 with that patch ones 2.4.11 is done? Linus?
I don't think that it's a good idea. Such patch is trivial - it can be done at any point in 2.5. Moreover, while it does clean some of the mess up, I don't see a lot of other stuff that would depend on it.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |