lkml.org 
[lkml]   [2001]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    On Sun, Jan 07, 2001 at 02:10:52PM -0500, jamal wrote:
    > On Sun, 7 Jan 2001, Matti Aarnio wrote:
    > > Read what I wrote about the issue to Alan.
    > > Ben's code has no problems with receiving VLANs with network
    > > cards which have "hardware support" for VLANs.
    >
    > OK. I suppose an skb->vlan_tag is passed to the driver and it will know
    > what to do with it (pass it on a descriptor etc).

    Sure, nice. WHY SHOULD THERE BE MORE LAYER-2 STUFF ADDED TO
    SKB OBJECTS ?

    One of important abstraction issues is to isolate device specific
    new things (like what VLAN/PVC/SVC is used at your favourtite
    802.1Q/ATM/X.25/FrameRelay connection).

    The less we leak that kind of things to SKB, the better, IMO.
    They are net_device issues, after all.

    Tell me (if you can), why packet sender calls hardware-header
    generation for packet, if the card can insert it for you ?
    Consider the structure of Ethernet MAC header, where is source
    address ? Where is the destination address ? If you write the
    destination, why should you not write the source there too ?

    No doubt some cards can fill in the source address while doing
    frame transmit, but is it worth the hazzle ?

    > cheers,
    > jamal

    /Matti Aarnio
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.021 / U:31.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site