[lkml]   [2001]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread

    On Sun, 28 Jan 2001, Manfred Spraul wrote:

    > And one more point for the Janitor's list:
    > Get rid of superflous irqsave()/irqrestore()'s - in 90% of the cases
    > either spin_lock_irq() or spin_lock() is sufficient. That's both faster
    > and better readable.
    > spin_lock_irq(): you know that the function is called with enabled
    > interrupts.
    > spin_lock(): can be used in hardware interrupt handlers when only one
    > hardware interrupt uses that spinlocks (most hardware drivers), or when
    > all hardware interrupt handler set the SA_INTERRUPT flag (e.g. rtc and
    > timer interrupt)

    This is not a bug and only helps to make drivers nonportable. Please,
    don't do this.

    bye, Roman

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:24    [W:0.018 / U:52.076 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site