Messages in this thread Patch in this message | | | Date | Thu, 18 Jan 2001 12:29:36 +0100 (CET) | From | Kai Germaschewski <> | Subject | Re: (2.4.0->2.4.1-pre8) config problem with PCMCIA causing link error |
| |
On Wed, 17 Jan 2001, Derek Wildstar wrote:
> With 2.4.0 thru 2.4.1-pre8 (could possibly be sooner than 2.4.0) > > PCMCIA_CONFIG_NETCARD is getting defined with CONFIG_PCMCIA, even when no > PCMCIA net cards are selected: > > 458 # PCMCIA network device support > 459 # > 460 CONFIG_NET_PCMCIA=y > 461 # CONFIG_PCMCIA_NETCARD is not set
This looks more like a counterexample to what you're saying. Also, I don't see how it could happen that CONFIG_PCMCIA_NETCARD=y without CONFIG_NET_PCMCIA=y, from looking at the drivers/net/pcmcia/Config.in. (It may be still possible somehow because there is CONFIG_NET_PCMCIA=y in defconfig).
> This causes the nonexistant drivers/net/pcmcia/pcmcia_net.o to try to be > linked. It looks like this is hepenning because CONFIG_NET_PCMCIA is > defined, but then CONFIG_PCMCIA_NETCARD is defined elsewhere. > > A patch is attached
Your patch is wrong. It removes the config variable CONFIG_NET_PCMCIA, which is referenced in drivers/net/Makefile:
subdir-$(CONFIG_NET_PCMCIA) += pcmcia
So the pcmcia net drivers will never be built.
I still don't see what's going wrong with the current code, but it can be simplified with the following patch. Does that work for you?
--Kai
diff -ur linux-2.4.1-pre8/Makefile linux-2.4.1-pre8.work/Makefile --- linux-2.4.1-pre8/Makefile Thu Jan 18 11:21:38 2001 +++ linux-2.4.1-pre8.work/Makefile Thu Jan 18 11:23:27 2001 @@ -155,7 +155,7 @@ DRIVERS-$(CONFIG_PCI) += drivers/pci/driver.o DRIVERS-$(CONFIG_MTD) += drivers/mtd/mtdlink.o DRIVERS-$(CONFIG_PCMCIA) += drivers/pcmcia/pcmcia.o -DRIVERS-$(CONFIG_PCMCIA_NETCARD) += drivers/net/pcmcia/pcmcia_net.o +DRIVERS-$(CONFIG_NET_PCMCIA) += drivers/net/pcmcia/pcmcia_net.o DRIVERS-$(CONFIG_PCMCIA_CHRDEV) += drivers/char/pcmcia/pcmcia_char.o DRIVERS-$(CONFIG_DIO) += drivers/dio/dio.a DRIVERS-$(CONFIG_SBUS) += drivers/sbus/sbus_all.o diff -ur linux-2.4.1-pre8/drivers/net/pcmcia/Config.in linux-2.4.1-pre8.work/drivers/net/pcmcia/Config.in --- linux-2.4.1-pre8/drivers/net/pcmcia/Config.in Sun Nov 12 03:56:58 2000 +++ linux-2.4.1-pre8.work/drivers/net/pcmcia/Config.in Thu Jan 18 11:23:33 2001 @@ -32,13 +32,4 @@ fi fi -if [ "$CONFIG_PCMCIA_3C589" = "y" -o "$CONFIG_PCMCIA_3C574" = "y" -o \ - "$CONFIG_PCMCIA_FMVJ18X" = "y" -o "$CONFIG_PCMCIA_PCNET" = "y" -o \ - "$CONFIG_PCMCIA_NMCLAN" = "y" -o "$CONFIG_PCMCIA_SMC91C92" = "y" -o \ - "$CONFIG_PCMCIA_XIRC2PS" = "y" -o "$CONFIG_PCMCIA_RAYCS" = "y" -o \ - "$CONFIG_PCMCIA_NETWAVE" = "y" -o "$CONFIG_PCMCIA_WAVELAN" = "y" -o \ - "$CONFIG_PCMCIA_XIRTULIP" = "y" ]; then - define_bool CONFIG_PCMCIA_NETCARD y -fi - endmenu
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |