Messages in this thread | | | Date | Wed, 10 Jan 2001 20:05:50 -0800 | From | David Hinds <> | Subject | Re: [PATCH] drivers/pcmcia/cs.c |
| |
On Wed, Jan 10, 2001 at 04:23:14PM -0200, Thiago Rondon wrote: > > Check kmalloc(). > > -Thiago Rondon > > --- linux-2.4.0-ac5/drivers/pcmcia/cs.c Fri Dec 29 20:35:47 2000 > +++ linux-2.4.0-ac5.maluco/drivers/pcmcia/cs.c Wed Jan 10 16:18:11 2001 > @@ -1458,6 +1458,8 @@ > s->functions = 1; > s->config = kmalloc(sizeof(config_t) * s->functions, > GFP_KERNEL); > + if (!s->config) > + return CS_OUT_OF_RESOURCE; > memset(s->config, 0, sizeof(config_t) * s->functions); > }
This is not a satisfactory fix; if that kmalloc ever fails, you also need to back out various things that were done higher up. You can't bail out at this spot.
-- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |