lkml.org 
[lkml]   [2000]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] alignment issue with ipchains
       From: NIIBE Yutaka <gniibe@chroot.org>
    Date: Sat, 09 Sep 2000 12:18:28 +0900

    I'd like to explain my point clearly. My point is that accessing
    with get_user as int is questionable. In my case, it's string. I
    don't think all the string argment to the kernel should be aligned.

    Thank you for the explanation.

    I agree with your logic, but not with the fix you sent here before.

    I would much rather see a test for the socket option cases that use
    the "val", and in those cases do the get_user calls. Ie. something
    like:

    if (optname == X || optname == Y || optname == Z || ...) {
    if(optlen>=sizeof(int)) {
    if(get_user(val, (int *) optval))
    ...
    }

    Could you send me a patch which fixes the problem in this way?

    Thank you.

    Later,
    David S. Miller
    davem@redhat.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:38    [W:0.029 / U:59.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site