lkml.org 
[lkml]   [2000]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: The INN/mmap bug


    On Sun, 17 Sep 2000, Marco d'Itri wrote:
    >
    > I added to block_write_full_page() the debugging code suggested by
    > Alexander Viro:
    >
    > if (inode->i_dev == 0x305 && inode->i_ino == 48991) // Md
    > printk("block_write_full_page: writing page %d, size %Ld\n",
    > page->index, inode->i_size);
    >
    > and I have just been able to trigger the bug (two times):

    Bug?

    How do you think updates get written back to disk when innd has made
    changes to its in-core file?

    Right. With block_write_full_page.

    > root@wonderland:vc/2:/var/lib/news$diff -u active active.ok
    > --- active Sun Sep 17 16:09:01 2000
    > +++ active.ok Sun Sep 17 21:03:16 2000
    > @@ -1,11 +1,11 @@
    > control 0000004774 0000004775 y
    > control.cancel 0000021917 0000021889 n
    > junk 0000001777 0000001768 y
    > -fido.ita.ridere 0000014632 0000014600 y
    > +fido.ita.ridere 0000014634 0000014600 y

    So? innd got two new articles.

    The above is what you want. If the active file wouldn't get updated, you'd
    never see any new articles ever again.

    Doesn't look like a bug to me.

    Linus

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:45    [W:0.027 / U:0.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site