Messages in this thread Patch in this message | | | Date | Wed, 13 Sep 2000 09:34:34 -0500 (CDT) | From | Chris Bednar <> | Subject | Re: [bad PATCH] - arch/ppc/config.in for 2.{3,4}.* to get PCI right on G4 |
| |
Sorry for the repeat... I submitted this a couple of days ago, but I probably should have targetted a couple of people, so I'll do that now.
The point is that there's some pollution in arch/ppc/config.in that doesn't allow a G4 user (for example) to configure a host of PCI devices. The problem is that both branches of a conditional are evaluated, so only the second ever matters. The thing looks perfectly valid to a shell-script writer's eye, but it doesn't work here.
I have been patching 2.4 this incorrect way for a long time, but only really got a working kernel lately (paulus' kernel via rsync).
---- Chris J. Bednar <http://optics.tamu.edu/~bednar/> Director, Distributed Computing Product Group http://AdvancedDataSolutions.com/
On Sun, 10 Sep 2000, Chris Bednar wrote:
> The following is a little patch I've been having to > do to get development kernels to configure PCI right on > my G4. I know it's not the right thing to do, but I've > never managed to figure out what's wrong with the original; > maybe somebody who understands config-speak will know. > > Anyway, without this trick, I can't configure > tulip ethernet, firewire, etc, so I'm still wondering > if it's just all a big mistake on my part - surely > someone else should have hit this problem... > > -------------------------------------------------------- > > --- linux-2.4.0-test8-pmac/arch/ppc/config.in-pciconf-prepatch Mon Aug 28 18:56:02 2000 > +++ linux-2.4.0-test8-pmac/arch/ppc/config.in Sat Sep 9 11:16:38 2000 > @@ -106,9 +106,9 @@ > else > if [ "$CONFIG_6xx" = "y" -o "$CONFIG_PPC64BRIDGE" = "y" ]; then > define_bool CONFIG_PCI y > - else > - # CONFIG_8xx > - bool 'QSpan PCI' CONFIG_PCI > +# -?huh?- else > +# -?huh?- # CONFIG_8xx > +# -?huh?- bool 'QSpan PCI' CONFIG_PCI > fi > fi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |