Messages in this thread | | | Date | Mon, 11 Sep 2000 08:48:24 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Reorg raid5 block xor routines |
| |
On Sat, 9 Sep 2000, Richard Henderson wrote: > > There are two main purposes to this reorg: > > * Split up the tremndously huge xor.c.
Looks ok, however:
- please use unified diffs. Standard context diffs are horrible.
- Please split this up the same way the checksums were split up: make the xor routine be an architecture-dependent library thing, with the "generic" slow one possibly just a regular library thing.
There's no reason to have alpha code in drivers/block. Just move it into arch/alpha/lib, etc, please?
You've done most of the work already, that last 1% would clean things up noticeably, and you could get rid of the ugly "Makefile knows architecture rules" stuff.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |