lkml.org 
[lkml]   [2000]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patchlet] Removing unneeded line in vmtruncate() (2.4.0-t8p1)
On Fri, 1 Sep 2000, Rasmus Andersen wrote:

> Hi.
>
> AFAICS, the line removed below is redundant. Comments?
>
> --- linux-240test8-pre1/mm/memory.c Thu Aug 10 16:29:54 2000
> +++ linux/mm/memory.c Fri Sep 1 22:00:16 2000
> @@ -986,7 +986,6 @@
> out_unlock:
> spin_unlock(&mapping->i_shared_lock);
> /* this should go into ->truncate */
> - inode->i_size = offset;
> if (inode->i_op && inode->i_op->truncate)
> inode->i_op->truncate(inode);
> return;

Rasmus, you introduced a bug because you removed the code but left the
comment around. now /* this should go into ->truncate */ is there and very
confusing - what should go into ->truncate?
Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site