Messages in this thread | | | From | Keith Owens <> | Subject | Re: Test-2.4.0-pre8 compile errors (netsyms vs netfilter duplicate defins) | Date | Wed, 09 Aug 2000 00:37:18 +1000 |
| |
On Tue, 8 Aug 2000 09:15:52 -0500 (CDT), Thomas Molina <tmolina@home.com> wrote: >On Tue, 8 Aug 2000, Keith Owens wrote: > >> On Tue, 8 Aug 2000 12:29:36 +0100, >> "Andrew Stubbs" <andrews@stusoft.com> wrote: >> >Errors compiling 2.4.0-test6-pre8 >> >============================================================================ >> >======= >> >ipv4/netfilter/netfilter.o(.kstrtab+0x8e): multiple definition of >> >`__kstrtab_ipt_unregister_target' >> >netsyms.o(.kstrtab+0xe0e): first defined here >> >> Duplicate EXPORT_SYMBOL statements. Remove one set from netsyms.c. > >Why remove the symbols from netsyms.c? Why not remove the duplicates >from the files in the netfilter subdirectory?
They are only needed if the netfilter code is compiled in. It just seemed easier to keep the EXPORT_SYMBOL() close to the code that defines the symbols. If they are in netsyms then you need #ifdef around them, netfilter has already handled that. Either would work, it is just my personal preference.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |