lkml.org 
[lkml]   [2000]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch-2.4.0-test6-pre8] fork.c FIXME removed (UPDATE)
Also sprach Matthew Wilcox:
} On Tue, Aug 08, 2000 at 03:49:08AM -0500, Bill Wendling wrote:
} > - /* Kill me slowly. UGLY! FIXME! */
} > - memcpy(&mm->start_code, &current->mm->start_code, 15*sizeof(unsigned long));
}
} why isn't the fix simply:
}
} memcpy(&mm->start_code, &current->mm->start_code, sizeof(struct mm_struct));
}
} ? looks a lot less ugly to me.
}
That code wouldn't work since start_code isn't the first element in the
structure. It's also a bit less efficient then just copying the fields
you are interested in IMHO :).

--
|| Bill Wendling wendling@ganymede.isdn.uiuc.edu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.536 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site