lkml.org 
[lkml]   [2000]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups
On Sun, Aug 27, 2000 at 10:28:14PM +0200, Kenneth Johansson wrote:
> Arnaldo Carvalho de Melo wrote:
>
> > #include <linux/config.h>
> > @@ -510,10 +511,7 @@
> > if (put_user(len, optlen))
> > return -EFAULT;
> >
> > - if (copy_to_user(optval, &val, len))
> > - return -EFAULT;
> > -
> > - return 0;
> > + return copy_to_user(optval, &val, len) ? -EFAULT : 0;
> > }
>
> What is this are you trying to compress the source code ?
> I like the old way better. I think it is faster to read and understand.

Same here. Linus, I didn't actually interpret your mail on the subject as
proposing changes like the one above. Care to enlighten this a bit ?

Philipp Rumpf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [W:0.195 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site