lkml.org 
[lkml]   [2000]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH][RFC] Adding KERN_* to all printk
From

I think all or almost all uses of the printk function should indicate its
severity, instead of relying on the default. So I want to ask if anybody has
any reason for NOT doing so.

Since it looks like I ended up being the defacto drivers/char/{rtc,nvram}.c odd
fixer, I made a patch for rtc.c which adds the severity to the three places
where it wasn't supplied and fixed one which was wrong.
Linus, please apply if you think it's correct.


diff -Naur linux-2.4.0-test7.orig/drivers/char/rtc.c linux-2.4.0-test7/drivers/char/rtc.c
--- linux-2.4.0-test7.orig/drivers/char/rtc.c Sat Aug 26 15:37:06 2000
+++ linux-2.4.0-test7/drivers/char/rtc.c Sat Aug 26 19:50:37 2000
@@ -633,7 +633,7 @@
}
}
}
- printk("rtc_init: no PC rtc found\n");
+ printk (KERN_ERR "rtc_init: no PC rtc found\n");
return -EIO;

found:
@@ -649,7 +649,7 @@
* Standard way for sparc to print irq's is to use
* __irq_itoa(). I think for EBus it's ok to use %d.
*/
- printk("rtc: cannot register IRQ %d\n", rtc_irq);
+ printk (KERN_ERR "rtc: cannot register IRQ %d\n", rtc_irq);
return -EIO;
}
#else
@@ -704,7 +704,8 @@
guess = "Digital DECstation";
}
if (guess)
- printk("rtc: %s epoch (%lu) detected\n", guess, epoch);
+ printk (KERN_INFO "rtc: %s epoch (%lu) detected\n", guess,
+ epoch);
#endif
#if RTC_IRQ
init_timer(&rtc_irq_timer);
@@ -783,7 +784,7 @@

spin_unlock_irq(&rtc_lock);

- printk(KERN_INFO "rtc: lost some interrupts at %ldHz.\n", freq);
+ printk (KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);

/* Now we have new data */
wake_up_interruptible(&rtc_wait);
--
Cesar Eduardo Barros
cesarb@nitnet.com.br
cesarb@dcc.ufrj.br
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site