lkml.org 
[lkml]   [2000]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cleanup on selection.c
From
Date
>>>>> "Matthew" == Matthew Wilcox <matthew@wil.cx> writes:

Matthew> On Fri, Aug 25, 2000 at 10:05:19AM -0300, Arnaldo Carvalho de
Matthew> Melo wrote:
>> /* does screen address p correspond to character at LH/RH edge of
>> screen? */

Matthew> this is wrong.

Matthew> return copy_from_user_ret(inwordLut, (u32 *)(arg+4),
Matthew> 32, -EFAULT);

Returning from inside a macro is really foul - it is very hard read
and debug.

Please change the code to

if (copy_from_user(foo, bar, boo))
return -EFAULT;
return 0;
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:38    [from the cache]
©2003-2011 Jasper Spaans