lkml.org 
[lkml]   [2000]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: DVD capacity bug for IDE CD's in linux-2.4.0-test6
Jens Axboe <axboe@suse.de> writes:
>On Tue, Aug 15 2000, Andries Brouwer wrote:
>> > Prior to linux-2.4.0-test2, the call to cdrom_get_last_written
>> > had been commented out.
>>
>> Ah - I may have been responsible for removing the `#if 0',
>> see the linux-kernel post of 9 Jun 2000 with subject `[PATCH] cdrom stuff'.
>> In my patch I had
>>
>> + if (!CDROM_CAN(CDC_CD_R | CDC_CD_RW))
>> goto use_toc;
>>
>> but the current kernel code has (in cdrom_get_last_written())
>>
>> if (!CDROM_CAN(CDC_CD_R | CDC_CD_RW | CDC_DVD_R | CDC_DVD_RAM))
>> goto use_toc;
>>
>> Do things improve if you go back to my version?

No.

However, adding the following to the beginning of
cdrom_get_toc_entry in ide/ide-cd.c does eliminate the problem:

if (!CDROM_STATE_FLAGS(drive)->toc_valid)
return -EINVAL;

Thanks for your quick attention to this problem.


Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.026 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site