lkml.org 
[lkml]   [2000]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: an assortment of memory alloc/dealloc errors
On Tue, Aug 08, 2000 at 06:40:17PM -0700, Dawson Engler wrote:

> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:686:usb_request_bulk: ERROR: Unchecked use of malloc'd var 'awd'
> /u2/engler/ic/linux-2.3.99/drivers/usb/usb.c:779:usb_request_irq: ERROR: Unchecked use of malloc'd var 'wd'

These functions are no longer in the most recent code.

> /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path
> /u2/engler/ic/linux-2.3.99/drivers/usb/plusb.c:391:plusb_alloc: ERROR: did not free skb on error path

These look like real errors. Deti, could you look into fixing these?

> /u2/engler/ic/linux-2.3.99/drivers/usb/usb-ohci.c:487:sohci_submit_urb: ERROR: did not free urb_priv on error path

The memory is freed in the call to urb_rm_priv, so this is a false
positive.

> /u2/engler/ic/linux-2.3.99/drivers/usb/usb-uhci.c:653:init_skel: ERROR: did not free s on error path

The memory is freed in the call to cleanup_skel, so this is also a false
positive.

Thanks for reporting these.

greg k-h

--
greg@(kroah|wirex).com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.071 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site