lkml.org 
[lkml]   [2000]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Werror compiler option problems with modules and devfs
    Neil Brown writes:
    > On Wednesday July 5, JJProg@cyberbury.net wrote:
    > >
    > > I understand that using Werror probably helps enforce cleaner code, but
    > > it definately does not work with modules. Also, I tried to figure out
    > > how to fix the warning with devfs, but I was unable to. Other than that,
    > > the kernel compiled without any warnings.
    > >
    > > Jeff Fielding
    > > JJProg@cyberbury.net
    >
    > --- linux/fs/devfs/base.c Thu Jul 6 10:43:07 2000
    > +++ linux-2.4.0-test3-pre3/fs/devfs/base.c Thu Jul 6 10:45:29 2000
    > @@ -2295,7 +2295,7 @@
    > #endif
    > } /* End Function devfs_read_inode */
    >
    > -static void devfs_write_inode (struct inode *inode)
    > +static void devfs_write_inode (struct inode *inode, int wait)
    > {
    > int index;
    > struct devfs_entry *de;
    >
    > worked for me (already sent to Linus)

    I'd like to know why the fuck the recent pre-patches did this:
    -static void devfs_write_inode (struct inode *inode, int wait)
    +static void devfs_write_inode (struct inode *inode)

    in the first place. 2.4.0-test2 had it right.

    Regards,

    Richard....
    Permanent: rgooch@atnf.csiro.au
    Current: rgooch@ras.ucalgary.ca

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:57    [W:0.020 / U:60.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site