Messages in this thread | | | Date | Mon, 31 Jul 2000 18:10:28 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Decrease hash table memory overhead |
| |
Linus Torvalds wrote: > Something as simple as "list_for_each()" can be a HUGE simplifier, and > make code a lot more readable. My favourite example is the PCI suspend > code, which is just a lot of grotty code walking the trees this way and > that, but that with some good organization resulted in functions that look > really simple and obvious. The "list_for_each()" macro is part of that.
As an aside, the PCI code doesn't do any locking when it updates or scans its lists... Pretty well known, but I suppose nothing has been done about it because the probably of a race occurring in practice is quite low.
Jeff
-- Jeff Garzik | Building 1024 | Yossarian lives. MandrakeSoft, Inc. |
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |