lkml.org 
[lkml]   [2000]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.2.17pre9 interactiveness under high IO
On Sun, Jul 02 2000, Marcelo Tosatti wrote:
> > This is wrong -- if the buffer is not queued because we are out of
> > free request slots, it has still already been locked at this point
> > (and _Req).
>
> if (!req) {
> if (rw_ahead)
> goto end_io;
> req = __get_request_wait(max_req, bh->b_rdev);
> }
>
> In case we fail to find a free request, bh->b_end_io is called, and
> it unlocks the buffer.

Ah yes, I was comparing to a similar case in 2.4. The buffer is
still marked BH_Req though, and thus counted as busy. Have you
thoroughly tested this change in 2.2 and made sure it didn't cause
any ext2 corruption? I saw some scary stuff in 2.4

--
* Jens Axboe <axboe@suse.de>
* SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.070 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site