Messages in this thread |  | | | Subject | Re: 2.2.17pre9: A typo fixed; some warnings squashed | | Date | Mon, 3 Jul 2000 11:19:55 +0100 (BST) | | From | Alan Cox <> |
| |
> > > - struct ei_device *ei_local = (struct ei_device *) dev->priv; > > > This is wrong > > Why? The variable isn't used anywhere I can see. If there is some hidden > use (perhaps only in SMP?), a comment would be useful.
The variable is used by non x86 platforms. Check the register access macros - its not obvious. In 2.3.x its marked to avoid the warnings
> movw %ax, %dx > > instead of (clearly wrong!): > > movw %eax,%edx
gcc generates movw %ax, %dx anyway but the wrong one doesnt work with old binutils.
> It might be right to stay with known broken tools to not rock the boat for > a stable kernel series, but _please_ get rid of that crap for 2.4
Agreed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
|  |