lkml.org 
[lkml]   [2000]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH #2] console lock grabbed too early in printk...
On Sun, 2 Jul 2000, Chris Lattner wrote:
> > Not a deadlock, you are breaking rules. A simple "don't do that" fixes
> > the deadlock.

> > printk takes only kernel-space addresses. Don't expect it to page
> > anything in for you. That work should be done in your driver, BEFORE
> > calling printk.

> I understand this, but I don't think this is optimal
> behavior... especially for quick debugging checks.

It sounds like you really need a private macro or private debugging
code, not a modification to a function which nearly all kernel code
calls at one time or another.

I don't think too many people are going to favor changing printk to be
optimal for "quick debugging checks"... which involve userland
addresses and/or paging. printk should be optimal, sure, but this is
NOT a case the core kernel needs to optimize for.


> I'll throw together a
> new patch that will hopefully address some problems...

What exactly are those problems?

Regards,

Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [from the cache]
©2003-2011 Jasper Spaans