lkml.org 
[lkml]   [2000]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [patch-2.4.0-test5] microcode_release needs no BKL.
    On Fri, 28 Jul 2000, Matti Aarnio wrote:
    > /* this is so trivial we don't need to lock_kernel() here */

    Ok, that is much better. Linus, here is an improved patch:

    --- linux/arch/i386/kernel/microcode.c Fri Jul 14 20:52:14 2000
    +++ work/arch/i386/kernel/microcode.c Fri Jul 28 17:25:03 2000
    @@ -145,11 +145,10 @@
    return 0;
    }

    +/* our specific f_op->release() method needs no locking */
    static int microcode_release(struct inode *inode, struct file *file)
    {
    - lock_kernel();
    clear_bit(MICROCODE_IS_OPEN, &microcode_status);
    - unlock_kernel();
    return 0;
    }


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:57    [W:0.018 / U:1.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site