lkml.org 
[lkml]   [2000]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch-2.4.0-test5] microcode_release needs no BKL.
    But Matti... usually I agree with you but here you are making no sense.
    Why should driver-specific methods contain comments about what other
    driver-specific methods should or should not implement? The place for such
    comments is sys_close() or filp_close() or anywhere in VFS (e.g. next to
    declaration of struct file_operations but _definitely_ not in every single
    driver that implements a particular method.

    So, BLK definitely does not belong in microcode_release(). Think about
    what you would think if you see it there? You would certainly think this:

    Aha, BKL is needed around bitmap manipulation - heh, so Linux is so
    primitive that it can't even get bitmap manipulations atomic...

    See what I mean?

    Regards,
    Tigran

    On Fri, 28 Jul 2000, Matti Aarnio wrote:

    > On Fri, Jul 28, 2000 at 04:18:10PM +0100, Tigran Aivazian wrote:
    > > Hi Linus,
    > >
    > > Someone seems to have added lock/unlock_kernel to
    > > arch/i386/kernel/microcode.c:microcode_release() without giving it due
    > > consideration. The patch below puts it back to how it was before.
    >
    > Please don't.
    >
    > Having those calls there (if only as comment text) reminds
    > of their need when next person comes around to look model
    > from those parts for their own beast of similar manner.
    >
    > > Regards,
    > > Tigran
    > >
    > > --- linux/arch/i386/kernel/microcode.c Fri Jul 14 20:52:14 2000
    > > +++ work/arch/i386/kernel/microcode.c Fri Jul 28 16:15:20 2000
    > > @@ -147,9 +147,7 @@
    > >
    > > static int microcode_release(struct inode *inode, struct file *file)
    > > {
    > > - lock_kernel();
    > > clear_bit(MICROCODE_IS_OPEN, &microcode_status);
    > > - unlock_kernel();
    > > return 0;
    > > }
    > >
    > > -
    > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > > the body of a message to majordomo@vger.rutgers.edu
    > > Please read the FAQ at http://www.tux.org/lkml/
    >


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:57    [W:0.021 / U:153.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site