lkml.org 
[lkml]   [2000]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: uPatch for mm/filemap.c
On Sat, Jul 15 2000, Roberto Fichera wrote:
> Hi All,
>
> I've notice a double page_cache_release() in
> mm/filemap.c:truncate_inode_pages(). Here is the patch
>
> --- linux-2.4.0-test4/mm/filemap.c.orig Sat Jul 15 16:33:17 2000
> +++ linux-2.4.0-test4/mm/filemap.c Sat Jul 15 16:33:47 2000
> @@ -199,7 +199,6 @@
>
> UnlockPage(page);
> page_cache_release(page);
> - page_cache_release(page);
>
> /*
> * We have done things without the pagecache lock,

This will give you serious problems, I doubt you have even tried running
for more than a couple of minutes with this? We are freeing the page
and a couple of lines further up we page_cache_get() the page -- alas,
two releases.

--
* Jens Axboe <axboe@suse.de>
* SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:0.061 / U:1.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site