Messages in this thread | | | Date | Mon, 6 Mar 2000 12:12:42 -0500 (EST) | From | Alexander Viro <> | Subject | Re: Nbd is broken |
| |
On Mon, 6 Mar 2000, Andrea Arcangeli wrote:
> I think the >512 sector request handling should be done with a precise > field in the request that is declared as clobbered (req->sector should > remains read_only, writeable only by the highlevel layer in the common > usage). A new req->driver_sector will be set by the highlevel layer always > correctly (also from end_request) and the lowlevel layer can > advance/overwrite it to do the larger block handling.
Ouch... Yes, we can do that, but... Is it really worth the trouble? Let's see: it will move the 'sector-skipping' code from error path to the main one (modulo names of fields) and will leave us with the things we are already doing in the 99% of drivers. Who else (aside of end_request()) needs to know ->sector of request under IO?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |