Messages in this thread | | | From | (Nick Holloway) | Subject | Re: [patch] 2.3.99-pre3-3: dev_alloc_name | Date | 23 Mar 2000 19:39:39 -0000 |
| |
Nick.Holloway@alfie.demon.co.uk (Nick Holloway) writes: > urban@svenskatest.se (Urban Widmark) writes: > > (But I don't understand your number of 27 that needs fixing, so maybe I'm > > way off here ... :) > > Tim Waugh said that changing "name" in "struct net_device" from "char*" > to "char[]" would mean changing a large number of net drivers, as they > currently assign directly to dev->name. > > I looked into drivers/net to see how big this problem was. A quick grep > for "dev->name *=" revealed the following files: > [...] > This is where my figure of 27 comes from.
This count is flawed. In addition to the ones picked out by the grep, there are also drivers that have:
static char devicename[9] = { 0, }; static struct net_device dev_el2[MAX_EL2_CARDS] = { { devicename, 0, 0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL }, };
These also need changing. Add about another dozen. Then add PCMCIA. Then add FDDI. Then add...
Someone would have to decide that changing dev->name from "char*" to "char[]" _really_ was the _right_ thing to do.
-- `O O' | Nick.Holloway@alfie.demon.co.uk // ^ \\ | http://www.alfie.demon.co.uk/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |