lkml.org 
[lkml]   [2000]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bsd disklabel detection
On Thu, 23 Mar 2000 Andries.Brouwer@cwi.nl wrote:

> So, if you want to detect BSDI at the outer level, you should not
> interrupt the msdos code, but add a new item to the list in check.c.
> Such a new bsd.c would be very similar to osf.c. If it is not
> the same, add it.
>
> But the osf.c stuff looks so similar to the bsd stuff, even the magic
> numbers are the same, that I conjecture that you already have what you want,
> no patch needed, just enable CONFIG_OSF_PARTITION.

You're right, except for one thing: msdos_partition is called before
osf_partition. Since the disklabel does have the 0x55aa signature,
msdos_partition will be hapy with whatever junk it finds in the partition
table, and thus osf_partition will never get a chance to run.

Would it be reasonable to switch the two, and also to update the docs so
that other people will know what to enable? If so, I'd be happy to come up
with the patch.

Thanks,
Ion

--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:57    [W:1.165 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site