Messages in this thread Patch in this message | | | Date | Sat, 11 Mar 2000 16:27:42 -0500 | Subject | Re: EXPORT_SYMTAB and 2.3.50 | From | tytso@mit ... |
| |
From: Keith Owens <kaos@ocs.com.au> Date: Fri, 10 Mar 2000 18:04:34 +1100
>The fact that EXPORT_SYMTAB should be in the Makefile or in the code appears >as a comment in some files. > >Here is an example in sb_common.c >... >/* FIXME: *grr* why can't the f**in Makefile do this for me ? */ >#define EXPORT_SYMTAB >... > >I think that 'somebody' has to choose how the things have to be >done.
I believe the problem caused by the sound drivers not compiling under 2.3.50 can be fixed with the following patch. I am not sure why the MI*OBJ macros were commented out, but this caused sound_syms.o and sb.o to be compiled without the -DEXPORT_SYMTAB option.
The patch to remove the gross hack mentioned above in sb_common.c is left as an exercise to the reader.
- Ted
--- drivers/sound/Makefile 2000/03/09 21:09:21 1.1 +++ drivers/sound/Makefile 2000/03/09 21:09:24 @@ -137,8 +137,8 @@ OX_OBJS := $(filter $(export-objs), $(obj-y)) M_OBJS := $(sort $(filter-out $(export-objs), $(obj-m))) MX_OBJS := $(sort $(filter $(export-objs), $(obj-m))) -#MI_OBJS := $(sort $(filter-out $(export-objs), $(int-m))) -#MIX_OBJS := $(sort $(filter $(export-objs), $(int-m))) +MI_OBJS := $(sort $(filter-out $(export-objs), $(int-m))) +MIX_OBJS := $(sort $(filter $(export-objs), $(int-m))) ifeq ($(CONFIG_LOWLEVEL_SOUND),y) O_OBJS += lowlevel/lowlevel.o - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |