Messages in this thread | | | Date | Fri, 04 Feb 2000 20:28:15 +0100 | From | Manfred Spraul <> | Subject | Re: [PATCH] fs/select.c cleanups. |
| |
Bill Wendling wrote: > > Here's a patch to clean up some things in the fs/select.c file. The first > is to reduce the number of times the do_pollfd() function is called by > moving the loop into the function. There was also a way to move kernel > locking closer to the code it needed to be near in the select() > functions. >
Could you please wait with this patch? It's unclear if it's allowed or illegal to call __get_free_page() while "current->state != TASK_RUNNING". __pollwait() does exactly that.
I've written a similar patch, but I'll wait until the allocation problem has settled down (the "2.2.15pre5: still very unstable" thread).
And _pollwait() ignores oom. Hmm. I think my patch is required. I'll merge your changes and forward the result to Linus. Ok? -- Manfred
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |