lkml.org 
[lkml]   [2000]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.3.48] initrd fix (Mike Galbraith)

If Mike doesn't do it, I will give it a try. Mike ?

Mit freundlichen Grüßen / kind regards

Frank Bernard


Frank Bernard Informationstechnik GmbH
vanity +49 700 FIREWALL (0700 FIREWALL) phone : +49 69 477169
Dipl.-Inform. Frank Bernard fax : +49 69 47885616
Wehrheimerstr. 9 email : fb@fbit.de
60389 Frankfurt www : http://www.fbit.de
Germany http://www.linuxwall.de

On Sun, 27 Feb 2000, Linus Torvalds wrote:

>
>
> Looks ok _except_ for this part that does
>
> - if (atomic_dec_and_test(&bdev->bd_openers)) {
> + if (atomic_dec_and_test(&bdev->bd_openers) && MAJOR(rdev) != RAMDISK_MAJOR) {
>
> in fs/block_dev.c..
>
> I see exactly what you're trying to do, I just disagree with it violently.
> I hate having these kinds of special cases in generic code - it turns them
> into non-generic code.
>
> It should be easily fixed in the initrd code itself, rather than in the
> generic code: turning it from a special case into a normal well-behaved
> case should be trivial. The way I would suggest is that initrd should just
> open the block device one extra time very early on, and then close the
> block device one extra time just before releasing all the initrd memory.
>
> Would you be willing to look at that solution instead?
>
> Linus
>




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [W:0.066 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site