lkml.org 
[lkml]   [2000]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: pci_enable_device()
Petr Vandrovec wrote:
> for current matroxfb release I read through PCI docs and decided that
> doing pci_enable_device() is right thing to do even for me. Unfortunately,
> now I have problem how to find, which of VGA devices was primary and which
> not.
> Is there some recommended solution for this task or should I return back
> to my old code, which thought that if device is not enabled, it is second
> head (and needs full initialization) and if it is enabled, it is primary
> head (initialized by BIOS and doing primary console)? I need this because
> of matroxfb cannot initialize all types of hardware around, so it
> initializes it only when it really needs.

Petr,

I think pci_enable_device is a good idea for all devices, since it does
other stuff than just twiddling PCI_COMMAND bits. fbdev devices are of
course a special case though :) I was thinking about something like the
following for s3fb...

s3fb_init_one()
save state of PCI_COMMAND
call pci_enable_device
handle POST, possibly requiring VGA I/O ports
disable I/O region decoding

--
Jeff Garzik | "Are you the police?"
Building 1024 |
MandrakeSoft, Inc. | "No ma'am. We're musicians."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [W:0.228 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site