lkml.org 
[lkml]   [2000]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 2.3.48] initrd fix (Mike Galbraith)
Date
Frank Bernard writes:
> Linus,
>
> please apply the attached fix to one of the next kernel versions.
> With it the broken initrd now works again.
>
> It's originally from Mike Galbraith <mikeg@weiden.de>, I've just done the
> line numbering for 2.3.48 and the "diff -ur" to apply it easier.

--- linux-2.3.48-pre3/drivers/block/rd.c Thu Feb 17 00:42:05 2000
+++ linux/drivers/block/rd.c Sat Feb 26 18:55:16 2000
@@ -126,7 +126,7 @@
int rd_prompt = 1; /* 1 = prompt for RAM disk, 0 = don't prompt */
int rd_image_start = 0; /* starting block # of image */
#ifdef CONFIG_BLK_DEV_INITRD
-unsigned long initrd_start,initrd_end;
+unsigned long initrd_start = 0,initrd_end = 0;
int mount_initrd = 1; /* zero if initrd should not be mounted */
int initrd_below_start_ok = 0;

Is there any reason (apart from making vmlinux and kernel binary images larger)
for explicitly initialising variables with 0 when they will be placed in the
BSS anyway?
_____
|_____| ------------------------------------------------- ---+---+-
| | Russell King rmk@arm.linux.org.uk --- ---
| | | | http://www.arm.linux.org.uk/~rmk/aboutme.html / / |
| +-+-+ --- -+-
/ | THE developer of ARM Linux |+| /|\
/ | | | --- |
+-+-+ ------------------------------------------------- /\\\ |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [from the cache]
©2003-2011 Jasper Spaans