lkml.org 
[lkml]   [2000]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Improved <linux/lists.h>
Bill Wendling wrote:
>
> Also sprach Borislav Deianov:
> } On Tue, Feb 22, 2000 at 07:02:53PM -0500, Jeff Garzik wrote:
> } >
> } > One technique which is used in the kernel is to, if possible, place the
> } > primary list_head member of a structure at the top of the struct.
> } >
> } > This allows you to reference the structure itself as if it were a list,
> } > sometimes saving you a few keystrokes...
> }
> } Sounds dodgy to me... You still need a cast, and then one day you'll
> } forget and rearange the fields of your struct and the compiler won't
> } even warn you. Maybe places in the kernel that do that should be
> } fixed?
> }
> Plus, as per the CodingStyle doc, it's a "feature" of C. One that escapes
> the mind of most programmers, especially newer ones. Saving keystrokes
> shouldn't be the goal. Speeding up code should be the goal.

Look at how the PCI code stores the list of pci_drivers...

--
Jeff Garzik |
Building 1024 | Viva la open source!
MandrakeSoft, Inc. |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site