lkml.org 
[lkml]   [2000]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch] free_filps locking?
On Wed, 23 Feb 2000, Manfred Spraul wrote:

> This code should be protected by lock_kernel().
>
> Do you use iBCS or any other unusual module? Perhaps a module doesn't
> call lock_kernel().

Does someone who knows iBCS want to look at this patch to see if they
think it's right? If so, there are a pile of other places in iBCS like
this..

Tim.
*/

--- open.c Sun Aug 16 17:34:08 1998
+++ open.c~ Wed Feb 23 18:18:17 2000
@@ -281,14 +281,19 @@ int ibcs_open(const char *fname, int fla
* switch to socket(), connect() and things will likely work
* as expected however.
*/
+ lock_kernel();
file = fget(fd);
- if (!file)
+ if (!file) {
+ unlock_kernel();
return fd; /* Huh?!? */
+ }
if (!S_ISSOCK(file->f_dentry->d_inode->i_mode)) {
fput(file);
+ unlock_kernel();
return fd;
}
fput(file);
+ unlock_kernel();

SYS(close)(fd);
args[0] = AF_UNIX;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:56    [from the cache]
©2003-2011 Jasper Spaans