Messages in this thread | | | From | Rusty Russell <> | Subject | Re: getting more that 4K out of a proc file? [PATCH] | Date | Mon, 14 Feb 2000 18:14:38 +1100 |
| |
In message <200002140658.HAA28041@oboe.it.uc3m.es> you write: > This was where I had to make a couple of reverse engineering decisions > in the rewrite of the generic read_prco. I decided there were three and > maybe more modes of use: > > 0) 1 page files (< 4k) > 1) more than single page files > 2) files where client controls ppos > 3) files where the client software supplies the buffer > > 0) is signalled in the old code by start=0. Maintained. > 1) is signalled in the old code by start<page. Needs changing. > 2) not entirely sure. > 3) is signalled in the old code by start>=page. Yerrghhh.
This seems wrong: start < page indicates (2): I assumed when writing it that the only other valid case was `start points into the page supplied, just maybe not the start of page').
There may well be a bug here. Rusty. -- Hacking time.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |