Messages in this thread | | | Date | Sat, 12 Feb 2000 22:24:06 -0800 | From | David Mosberger <> | Subject | Re: Softnet/eepro100 driver conversion bug in 2.3.43pre8? |
| |
>>>>> On Sat, 12 Feb 2000 18:19:53 -0800, "David S. Miller" <davem@redhat.com> said:
davidm> Date: Sat, 12 Feb 2000 17:31:20 -0800 From: David davidm> Mosberger <davidm@hpl.hp.com>
davidm> The following patch seems to fix the problem for me. I davidm> think the cmpxchg should be #ifdef'd on HAVE_CMPXCHG but in davidm> our experience, atomicity is important for updating davidm> cmd_status, so if you can't do this atomically, you're davidm> probably hosed anyhow (you'll get lots of Tx timeouts, at davidm> least).
davem> I don't think it needs to be atomic at all.
That _sounds_ reasonably, I agree, but eepro100 gets tx timeouts very frequently if the access to "status" is not atomic. I agree this doesn't sound like the right solution, but I don't think it's worth spending more time on this until the driver gets replaced with the "other" eepro100 driver.
--david
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |