[lkml]   [2000]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] mm->rss is modified without page_table_lock held
    At 21.29 08/12/00 +0100, Rasmus Andersen wrote:

    >The following patch moves the page_table_lock in mm/* to cover the
    >modification of mm->rss in 240-test12-pre7. It was inspired by a
    >similar patch from davej(?) which covered too much, AFAIR. The item
    >is on Tytso's ToDo list.


    >@@ -1076,7 +1076,9 @@
    > flush_icache_page(vma, page);
    > }
    >+ spin_lock(&mm->page_table_lock);
    > mm->rss++;
    >+ spin_unlock(&mm->page_table_lock);


    Why we couldn't use atomic_inc(&mm->rss) here and below, avoiding to wrap
    the inc with a spin_lock()/spin_unlock() ?

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 12:51    [W:0.020 / U:13.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site