lkml.org 
[lkml]   [2000]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][RFC] Converting drivers/net/rcpci45.c to new PCI API
    Rasmus Andersen <rasmus@jaquet.dk> écrit :
    [...]
    > There are some other cleanups I want to do, and I need to make my indentation
    > match the drivers, but that will be after the basic conversion is done.
    >
    >
    > --- linux-240-t13-pre1-clean/drivers/net/rcpci45.c Sat Nov 4 23:27:08 2000
    > +++ linux/drivers/net/rcpci45.c Thu Dec 14 21:41:17 2000
    [...]
    > @@ -155,71 +153,29 @@
    > static int RC_allocate_and_post_buffers(struct net_device *, int);
    >
    >
    > -/* A list of all installed RC devices, for removing the driver module. */
    > -static struct net_device *root_RCdev;
    > +static struct pci_device_id rcpci45_pci_table[] __devinitdata = {
    > + { RC_PCI45_VENDOR_ID, RC_PCI45_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID, },
    > + { }
    > +};
    > +MODULE_DEVICE_TABLE(pci, rcpci_pci_table);
    >
    > -static int __init rcpci_init_module (void)
    > +static void rcpci45_remove_one(struct pci_dev *pdev)
    ^-> __exit
    [...]
    > - if (pci_enable_device(pdev))
    > - break;
    > - pci_set_master(pdev);
    > + unregister_netdev(dev);
    > + iounmap((void *)dev->base_addr);
    > + free_irq(dev->irq, dev);

    I'd rather inhibit irq first then release the ressources.
    + free_irq(dev->irq, dev);
    + iounmap((void *)dev->base_addr);
    + unregister_netdev(dev);

    --
    Ueimor
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.022 / U:30.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site