[lkml]   [2000]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] link time error in drivers/mtd (240t13p2)
    On Sun, 17 Dec 2000, Keith Owens wrote:

    > Messing about with conditional compilation because the link order is
    > incorrect is the wrong fix. The mtd/Makefile must link the objects in
    > the correct order.

    The conditional compilation is far more obvious to people than subtle
    issues with link order. So I prefer to avoid the latter at all costs.

    I have to have some conditional compilation in my tree to allow it to
    compile under 2.0 uClinux. Admittedly that doesn't have to get into 2.4,
    but I obviously prefer the code in 2.4 to be as close to my working copy
    as possible.

    I'll poke at it and try to come up with a cleaner solution. It may be that
    I can shift all the conditional stuff off into the compatmac.h and leave
    the 'real' code path in a cleaner state than the current one.

    > 2.4.0-test13-pre2 almost does that, the only obvious problem is that
    > cfi_probe appears before cfi_cmdset. Move cfi_probe to link after
    > cfi_cmdset, do you still get link order problems with the 2.4.0-test11
    > version of include/linux/mtd.h?

    I haven't had problems. But the possibility exists.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 12:52    [W:0.022 / U:2.756 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site