lkml.org 
[lkml]   [2000]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: INIT_LIST_HEAD marco audit
    Thinko.

    Question is... Adam Richter posted a patch for i2o_lan.c that does
    this...

    static struct tq_struct i2o_post_buckets_task = {
    list: LIST_HEAD_INIT(i2o_post_buckets_task.list),
    sync: 0,
    routine: (void (*)(void *))i2o_lan_receive_post,
    data: (void *) 0
    };

    If that's correct then is the only fix for structures similar to
    tcic_task to type cast the routine?

    Alan Cox wrote:
    >
    > > -static struct tq_struct tcic_task = {
    > > - routine: tcic_bh
    > > +DECLARE_TASK_QUEUE(tcic_task);
    > > +struct tq_struct run_tcic_task = {
    > > + routine: (void (*)(void *)) tcic_bh
    > > };
    >
    > Why remove the 'static' ?

    --

    =====================================================================
    Mohammad A. Haque http://www.haque.net/
    mhaque@haque.net

    "Alcohol and calculus don't mix. Project Lead
    Don't drink and derive." --Unknown http://wm.themes.org/
    batmanppc@themes.org
    =====================================================================
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.020 / U:90.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site