lkml.org 
[lkml]   [2000]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] NR_RESERVED_FILES broken in 2.4 too

    On Sun, 10 Dec 2000, Tigran Aivazian wrote:

    > problem (e.g. you mentioned something about allocating more than NR_FILES
    > on SMP -- what do you mean?) which you are not explaining clearly.

    E.g. situation, only one file struct left for allocation. One CPU goes
    into get_empty_filp and before kmem_cache_alloc unlocks file_list,
    another CPU gets also into get_empty_filp and locks file_list at the
    top and goes on the same path, the end result potentially can be both
    will increase nr_files instead of only one. But I don't think it's a
    big issue at *present* that could cause any problems ...

    > You just say "it is broken and here is the patch" but that, imho, is not
    > enough. (ok, one could overcome the laziness and actually _read_ your
    > patch to see what you _think_ is broken but surely it is better if you
    > explain it yourself?).

    Sorry I didn't explain, I thought it's short enough and significantly
    faster to understand reading the code then my poor English ;)

    Szaka

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:52    [W:0.021 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site