Messages in this thread |  | | | Subject | Re: [NEW DRIVER] firestream | | Date | Thu, 23 Nov 2000 09:22:09 +0100 (MET) | | From | (Rogier Wolff) |
| |
Peter Samuelson wrote:
> > +int loopback = 0; > > +int fs_debug = 0; > > +struct fs_dev *fs_boards = NULL;
> Aside from the 'static' issue already mentioned, these should be left > uninitialized. ('gcc -fassume-bss-zero' would be nice, but then again > in userspace it rarely matters.)
Hi Peter, thanks for the feedback.
Actually, I have an opinion on this matter: If the initialization value doesn't really matter that much, I like leave out the initialization, as you suggest.
However, if my code assumes that the compiler needs to initialize the variable one way or another, I want to put in the initialization, even if that means an "= 0;" which is already the default.
This is a form of documentation.
Roger.
-- ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2137555 ** *-- BitWizard writes Linux device drivers for any device you may have! --* * There are old pilots, and there are bold pilots. * There are also old, bald pilots. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |