Messages in this thread | | | Date | Mon, 9 Oct 2000 22:17:36 -0700 (PDT) | From | James Simmons <> | Subject | Re: Why 2 cli in vga_vesa_blank? |
| |
> > While working on vgacon I noticed their are 2 cli() in vga_vesa_blank > > that are excuted one after another. Is their are a reason for this or > > shoudl it be just one cli()? > > If you look at vgacon.c you still see remains of what the code used to > look like. Now comapare with vga16fb.c and it is clear what happened.
After I sent the message I see what was bothering me. Actually the code in vgacon is correct and their is a bug in vga16fb with its own version of vga_vesa_blank. I was actually looking at vga16fb instead of vgacon. My mistake especially since both codes are som much alike. In vga_vesa_blank in vga16fb you have:
cli(); Seq... Crt...
/* save orginal ... if (!info->vesa_blanked) { ... cli();
Where it should be as in vgacon.c:
vga_vesa_blank(..) { if (!info->vesa_blanked) { cli(); Seq... Crt... sti(); ....
}
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |