lkml.org 
[lkml]   [2000]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-2.4.0-test9
   Date: 	Tue, 3 Oct 2000 09:43:35 -0700 (PDT)
From: Linus Torvalds <torvalds@transmeta.com>

- pre8:
- initialize to zero -> put it in the .bss instead

Can the person who made these changes in tcp_ipv4.c talk
to me?

That particular instance screwed up all the cache line games I was
playing there for the hash tables and locks. The
"__tcp_clean_cacheline_pad" sitting around these changes should have
been a clue that something more clever than usual was going on here.

These items are specifically placed into the data section, not the
BSS, because these alignment games are not possible in the BSS.

This kind of stuff is why I like networking changes to go through me
whenever possible, to catch these sorts of misunderstandings. Alas I
was away for a week, so this time it slipped through :-)

Later,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:39    [W:0.062 / U:4.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site