lkml.org 
[lkml]   [2000]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Listed in 2.4 headers as:

    #define mem_map_reserve(p) set_bit(PG_reserved, &p->flags)
    #define mem_map_unreserve(p) clear_bit(PG_reserved, &p->flags)

    ...but should be:

    #define mem_map_reserve(p) set_bit(PG_reserved, &((p)->flags))
    #define mem_map_unreserve(p) clear_bit(PG_reserved, &((p)->flags))

    Because of the 'void *' nature of the 2nd parameter to set_bit/clear_bit,
    the compiler is not picking up this error. Either expression generates
    a pointer, but not the same values.

    Might as well also wrap the parameter 'p' with parentheses in the
    subsequent macros, mem_map_inc_count() and mem_map_dec_count(),
    for clarity.

    CC me if needed. I'm not on this list.

    -Kevin Lawton
    Plex86 project
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 12:45    [W:0.019 / U:4.388 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site