Messages in this thread | | | Date | Tue, 17 Oct 2000 12:36:19 -0500 | From | Bill Wendling <> | Subject | Re: Patch to remove undefined C code |
| |
Also sprach Bernd Schmidt: } > Looking at the above code, I noticed that there are a lot of ++ } > operations. I rewrote the code as: } > } > setup_from[0] = setup_from[1] = eaddrs[0]; } > setup_from[2] = setup_from[3] = eaddrs[1]; } > setup_from[4] = setup_from[5] = eaddrs[2]; } > setup_from += 6; } > } > I compiled using "gcc -S -Wall -O2 -fomit-frame-pointer -m486" to generate } > the assembler code. The old code is 17 instructions long and the new code } > is 11 instructions. As well as being shorter, simple timing test indicate } > that the new code is significantly quicker. } } This is something the compiler ought to know about. } A compiler can only guess so much. Don't look to a compiler to fix poorly written code...
-- || Bill Wendling wendling@ganymede.isdn.uiuc.edu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
| |