Messages in this thread Patch in this message |  | | | From | Peter Samuelson <> | | Date | Sat, 29 Jan 2000 22:30:56 -0600 (CST) | | Subject | Re: [KBUILD] 2.3.41 config: suggested [PATCH] |
[Andrzej Krzysztofowicz] > Notice, that according to Documentation/kbuild/config-language.txt in > the clause > > dep_bool 'txt' CONFIG_VAR $FOO > > if $FOO = m, CONFIG_VAR is forced to "n", no choice (as "m" is not a > legal value for a "bool" variable).
Hmmm. True.
> So: > - either documentation (and, consequently, all parsers) should be modified > - or the patch included should be applied...
I think that it is useful to have a construct that means what someone apparently thought dep_bool meant, i.e. a bool which can only be 'y' if a corresponding tristate is not 'n'. *Any* compile-time options to modules could use this. Those filesystem R/W options are just examples of where this is useful.
So if it's up to a vote, I say change the parsers. (Of course, I know it isn't, but anyway....) Peter
[Here's a start. Untested, undocumented, etc.]
--- scripts/Configure.pre-depbool Sat Jan 29 22:26:55 2000 +++ scripts/Configure.post-depbool Sat Jan 29 22:27:47 2000 @@ -299,13 +299,10 @@ var=$2 shift 2 while [ $# -gt 0 ]; do - case "$1" in - m | n) + if [ "$1" = "n" ]; then define_bool "$var" "n" return - ;; - esac - shift + fi done bool "$ques" "$var" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
|  |