Messages in this thread | | | Date | Wed, 26 Jan 2000 17:32:10 -0500 (EST) | From | Ben LaHaise <> | Subject | Re: buggy GFP_KERNEL allocators |
| |
Hello Alexey,
On Wed, 26 Jan 2000 kuznet@ms2.inr.ac.ru wrote:
> Hello! > > > + current->state = TASK_RUNNING; /* We *must* do this before touching userspace! */ > > This smells suspiciously. Page fault code should not stuck only because > task state is not running. It contaradicts all the idea behind wait queues. > > Essentially, fault is like signal. It must move task state to running.
Applying the change to the page fault handler might just be the right thing to do, and in fact it would make sense in 2.3 to have the fault handler also switch to lazy tlb mode if the task has to perform io. The fault handler does neither of these things right now, and in fact this was causing occasional stuck tasks if the fault ended up calling schedule before changing current->state.
-ben
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |