Messages in this thread | | | Date | Tue, 18 Jan 2000 00:05:05 +0100 | From | Guest section DW <> | Subject | Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1 |
| |
On Mon, Jan 17, 2000 at 01:38:32AM +0000, Alan Cox wrote:
> > Good driver should not do partition-table reads in the first place. > > What about drivers where the partition table is the only way to recover > the geometry the windows driver picked ? Are there better approaches I've > missed
It is none of the driver's business to worry about disk geometry. The driver does not need it itself, but only thinks that fdisk and/or LILO might want to know. But fdisk and LILO do a much better job - they examine the partition table much more carefully than some SCSI drivers do. No, code like that in scsicam_bios_param() is entirely ridiculous, and only does harm.
[On the other hand, there is no hurry in changing either. Every change will cause problems for a few people, so even though it is entirely wrong I left it for the time being.]
Andries
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
| |